Skip to content

Conversation

francisoliverlee
Copy link
Member

@francisoliverlee francisoliverlee commented May 22, 2022

What is the purpose of the change

fix #450

Brief changelog

  1. add pull consumer config
  2. add push consumer config
  3. delete consumer config , because consumer can be pull or push, usr must be sure with it.
  4. todo: rocketmq broker or client should not allowed :
  • same consumer group , same topic, consumer instances sub different tag
  • same consumer group, consumer instances both pull and push the same topic
  • same consumer group, consumer instances both clustering and broadcating topics

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • [] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • [] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • [] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist.
  • [] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • [] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Copy link
Member

@ShannonDing ShannonDing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RongtongJin RongtongJin merged commit 1aae0cd into apache:master May 30, 2022
@RongtongJin RongtongJin added this to the 2.2.3 milestone Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More than one client is created when consumer.group and consumer.topic is used in application.properties
3 participants