Skip to content

feat: support lite pull consumer #881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 13, 2022
Merged

feat: support lite pull consumer #881

merged 5 commits into from
Aug 13, 2022

Conversation

lampnick
Copy link
Contributor

@lampnick lampnick commented Aug 3, 2022

What is the purpose of the change

feat: support lite pull consumer

Brief changelog

feat: support lite pull consumer

Verifying this change

feat: support lite pull consumer

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@ShannonDing ShannonDing linked an issue Aug 3, 2022 that may be closed by this pull request
when will the pull consumer be officially used？Thanks! #802
Closed
ShannonDing
ShannonDing reviewed Aug 8, 2022
View reviewed changes
@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2022 •
edited
Loading

Codecov Report

Merging #881 (addadf7) into master (5aa04a2) will decrease coverage by 1.19%.
The diff coverage is 0.19%.

@@            Coverage Diff             @@
##           master     #881      +/-   ##
==========================================
- Coverage   25.01%   23.81%   -1.20%     
==========================================
  Files          51       52       +1     
  Lines        6665     7105     +440     
==========================================
+ Hits         1667     1692      +25     
- Misses       4772     5187     +415     
  Partials      226      226
Impacted Files Coverage Δ
consumer/option.go 20.86% <0.00%> (-2.85%) ⬇️
consumer/pull_consumer.go 0.00% <0.00%> (ø)
consumer/strategy.go 75.36% <ø> (ø)
internal/utils/namespace.go 0.00% <0.00%> (ø)
internal/utils/string.go 0.00% <0.00%> (ø)
primitive/result.go 0.00% <0.00%> (ø)
consumer/consumer.go 17.85% <3.12%> (+1.38%) ⬆️
internal/response.go 0.00% <0.00%> (ø)
consumer/offset_store.go 65.14% <0.00%> (+0.29%) ⬆️
... and 2 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@ShannonDing ShannonDing added this to the 2.2.0 milestone Aug 8, 2022
@ShannonDing ShannonDing added the enhancement New feature or request label Aug 8, 2022
@ShannonDing ShannonDing merged commit ae76839 into apache:master Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShannonDing ShannonDing ShannonDing left review comments

@cserwen cserwen Awaiting requested review from cserwen

@maixiaohai maixiaohai Awaiting requested review from maixiaohai

@wenfengwang wenfengwang Awaiting requested review from wenfengwang

@xujianhai666 xujianhai666 Awaiting requested review from xujianhai666

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.

when will the pull consumer be officially used？Thanks!
3 participants
@lampnick @codecov-commenter @ShannonDing