Skip to content

[ISSUE #790] use uber atomic lib to avoid atomic value data race. #866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 25, 2022
Merged

[ISSUE #790] use uber atomic lib to avoid atomic value data race. #866

merged 3 commits into from
Jul 25, 2022

Conversation

lifepuzzlefun
Copy link
Contributor

@lifepuzzlefun lifepuzzlefun commented Jul 23, 2022 •
edited
Loading

fix #790

in golang direct read from atomic int64 will cause data race
see https://stackoverflow.com/questions/54090404/what-is-causing-this-data-race

@lifepuzzlefun
Copy link
Contributor Author

@ShannonDing @guyinyou @cserwen

@lifepuzzlefun lifepuzzlefun changed the title use uber atomic lib to avoid atomic value data race. [ISSUE #790] use uber atomic lib to avoid atomic value data race. Jul 23, 2022
@guyinyou
Copy link
Contributor

wonderful

@ShannonDing ShannonDing merged commit b6d6f07 into apache:master Jul 25, 2022
@ShannonDing ShannonDing added the enhancement New feature or request label Jul 25, 2022
@ShannonDing ShannonDing added this to the 2.1.1 milestone Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@guyinyou guyinyou guyinyou approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
2.1.1
Development

Successfully merging this pull request may close these issues.

bug: some data race found in rocketmq-client-go
3 participants
@lifepuzzlefun @guyinyou @ShannonDing