fix long time block when remote endpoint crash. #816
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et ops when remote endpoint crash. 2. enable tcp keep alive.
|
just add common use case of golang net programming see https://github.com/gorilla/websocket/pull/763/files and sarama kafka go cient. https://github.com/Shopify/sarama/blob/9904b379913b586cb1b9f77f63a3d0c8e5f9932a/broker.go#L879-L897 |
added 2 commits
April 21, 2022 10:59
2. change default read/write Deadline to 120 sec. 3. close connection when set deadline fail.
|
@guyinyou @Git-Yang @maixiaohai can you take a look? |
|
look good to me 👍 |
guyinyou
approved these changes
Apr 21, 2022
guyinyou
approved these changes
Apr 21, 2022
|
@ShannonDing @cserwen @xujianhai666 can you take a look? |
duhenglucky
approved these changes
Apr 22, 2022
cserwen
approved these changes
Apr 22, 2022
RongtongJin
approved these changes
Apr 22, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #817
add tcp conn write and read deadline to avoid long time block socket ops when remote endpoint crash.
enable tcp keep alive.
remove request from responseTable when InvokeAsync.
doRequest close socket connection with destory call.