Skip to content

[ISSUE #728] client shutdown abnormally #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 25, 2022
Merged

[ISSUE #728] client shutdown abnormally #729

merged 4 commits into from
Jul 25, 2022

Conversation

Git-Yang
Copy link
Member

What is the purpose of the change

#728

Brief changelog

  • Add admin instance Map in rmqClient
  • Add instance count in rmqClient
  • Shutdown only when all instances no longer use rmqClient

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@wenfengwang
Copy link
Member

@Git-Yang Hi Yang, I understand the problem, but i can not understand why use admin to resolve the problem?

@Git-Yang
Copy link
Member Author

@Git-Yang Hi Yang, I understand the problem, but i can not understand why use admin to resolve the problem?

Thanks for your comment. First explain that it is not to use admin to solve this problem.
Producer, Consumer, and Admin all rely on the client at the bottom, so the producer, consumer, and admin instances that use the same client instance need to be managed in the client. Otherwise, calling shutdown on any of them will cause other instances to become unavailable.

@Git-Yang
Copy link
Member Author

@wenfengwang Could you please review it again for me?

Git-Yang and others added 2 commits December 21, 2021 14:36
@Git-Yang
[ISSUE apache#757] Fix GetHeader type conflict
a5766d3 
Signed-off-by: zhangyang <Git_Yang@163.com>
@Git-Yang
[ISSUE apache#728] Optimize client instance management
6bcbfb6 
Signed-off-by: zhangyang21 <zhangyang21@xiaomi.com>
@Git-Yang
Copy link
Member Author

#758

@Git-Yang Git-Yang requested a review from wenfengwang December 23, 2021 07:15
@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 16, 2022
@stale stale bot closed this Apr 30, 2022
@ShannonDing ShannonDing reopened this Jul 21, 2022
@stale stale bot removed the stale label Jul 21, 2022
@ShannonDing ShannonDing linked an issue Jul 21, 2022 that may be closed by this pull request
[Bug] Client shutdown logic optimization #728
Closed
@ShannonDing ShannonDing added the enhancement New feature or request label Jul 21, 2022
@ShannonDing ShannonDing merged commit 9ce8e66 into apache:master Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenfengwang wenfengwang Awaiting requested review from wenfengwang

@cserwen cserwen Awaiting requested review from cserwen

@maixiaohai maixiaohai Awaiting requested review from maixiaohai

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Client shutdown logic optimization
3 participants
@Git-Yang @wenfengwang @ShannonDing