Skip to content

[ISSUE #688] fix: type assert panic #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 5, 2021
Merged

[ISSUE #688] fix: type assert panic #697

merged 1 commit into from
Jul 5, 2021

Conversation

fengberlin
Copy link
Contributor

The sync.Map store the value 0, its type is int, but in that code before fixed, the value Load by sync.Map is asserted as int64, so cause the type assert panic.

@fengberlin
Copy link
Contributor Author

Please continue reviewing my reopen PR. Thanks.
@wenfengwang

@wenfengwang wenfengwang linked an issue Jul 5, 2021 that may be closed by this pull request
Error conversion: int to int64 in the consumer.PullConsumer #688
Closed
@wenfengwang wenfengwang changed the title fix: type assert panic [ISSUE #688] fix: type assert panic Jul 5, 2021
@wenfengwang wenfengwang merged commit 2bdc662 into apache:master Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenfengwang wenfengwang wenfengwang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error conversion: int to int64 in the consumer.PullConsumer
2 participants
@fengberlin @wenfengwang