Support log level set and add more log in offset. #489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #489 +/- ##
==========================================
+ Coverage 24.77% 24.82% +0.04%
==========================================
Files 49 49
Lines 5723 5736 +13
==========================================
+ Hits 1418 1424 +6
- Misses 4102 4109 +7
Partials 203 203
Continue to review full report at Codecov.
|
vongosling
reviewed
Jun 2, 2020
| @@ -255,6 +255,12 @@ func (r *remoteBrokerOffsetStore) persist(mqs []*primitive.MessageQueue) { | |||
| rlog.LogKeyUnderlayError: err.Error(), | |||
| "offset": off, | |||
| }) | |||
| } else { | |||
| rlog.Info("update offset to broker success", map[string]interface{}{ | |||
There was a problem hiding this comment.
update offset [to broker], “to broker” is redundant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.