Skip to content

[ISSUE #471] The message mode, ctype and where was wrong in the heartbeat data #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2020
Merged

[ISSUE #471] The message mode, ctype and where was wrong in the heartbeat data #472

merged 1 commit into from
Apr 24, 2020

Conversation

DandelionJR
Copy link
Contributor

The message mode, ctype and where was wrong in the heartbeat data，now we can get them form inner client

@ShannonDing
Copy link
Member

Hi, could you please move this PR to the native branch?
we should not modify the branch which has been released.

@ShannonDing ShannonDing added the bug Something isn't working label Apr 21, 2020
@ShannonDing ShannonDing linked an issue Apr 21, 2020 that may be closed by this pull request
The message mode was wrong in the heartbeat data. #471
Closed
ShannonDing
ShannonDing requested changes Apr 22, 2020
View reviewed changes
Copy link
Member

@ShannonDing ShannonDing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should not create PR on the released branch, could you pls change it to the native branch?

@DandelionJR DandelionJR changed the base branch from v2.0.0 to native April 22, 2020 05:24
@DandelionJR
Copy link
Contributor Author

Sorry, my first submission is a bit unskilled, now is ok. may I ask what can be merged and released in this iteration

@ShannonDing ShannonDing changed the title #471 The message mode, ctype and where was wrong in the heartbeat data [ISSUE #471] The message mode, ctype and where was wrong in the heartbeat data Apr 24, 2020
@ShannonDing ShannonDing merged commit 0897f19 into apache:native Apr 24, 2020
@ShannonDing ShannonDing added this to the 2.1.0 milestone Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShannonDing ShannonDing ShannonDing approved these changes

@wenfengwang wenfengwang Awaiting requested review from wenfengwang

@xujianhai666 xujianhai666 Awaiting requested review from xujianhai666

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

The message mode was wrong in the heartbeat data.
2 participants
@DandelionJR @ShannonDing