[improve][broker] Support cleanup replication cluster and allowed cluster when cluster metadata teardown
#23561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en cluster metadata teardown
…ter metadata teardown
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #23561 +/- ##
============================================
+ Coverage 73.57% 74.33% +0.75%
- Complexity 32624 34427 +1803
============================================
Files 1877 1943 +66
Lines 139502 147083 +7581
Branches 15299 16214 +915
============================================
+ Hits 102638 109331 +6693
- Misses 28908 29315 +407
- Partials 7956 8437 +481
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Technoboy-
approved these changes
Nov 12, 2024
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 20, 2024
…cluster` when cluster metadata teardown (apache#23561) (cherry picked from commit 0969869) (cherry picked from commit 0f5aa5c)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 20, 2024
…cluster` when cluster metadata teardown (apache#23561) (cherry picked from commit 0969869) (cherry picked from commit 0f5aa5c)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 21, 2024
…cluster` when cluster metadata teardown (apache#23561) (cherry picked from commit 0969869) (cherry picked from commit 0f5aa5c)
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
…cluster` when cluster metadata teardown (apache#23561)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When executing the
delete-cluster-metadatacommand, it should remove the current cluster from thereplication clusterandallowed cluster, otherwise the cluster will still replicate the data to a deleted cluster.Modifications
Support cleanup
replication clusterandallowed clusterwhen cluster metadata teardownDocumentation
docdoc-requireddoc-not-neededdoc-complete