This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Fix custom op multi-gpu scaling #9283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
|
||
| std::vector<Engine::VarHandle> vars; | ||
| for (const auto& i : arrs) vars.push_back(i.var()); | ||
| Engine::Get()->PushSync([=](RunContext rctx) { |
There was a problem hiding this comment.
Will worker thread and main thread push operations to the engine at the same time?
There was a problem hiding this comment.
That's fine. Engine is thread safe
|
Just FYI, every GPU-instance has two GPUs present, so feel free to write a test for this case. |
anirudh2290
reviewed
Jan 5, 2018
| cv_.wait(lock, [&] {return !q_.empty() || destructing_;}); | ||
| while (!q_.empty()) { | ||
| auto fn = q_.front(); | ||
| lock.unlock(); |
There was a problem hiding this comment.
What happens when after we unlock, something is pushed to the queue ? Will we pop the correct item from the queue ?
There was a problem hiding this comment.
there is on 1 consumer thread, so its ok
szha
pushed a commit
that referenced
this pull request
Jan 5, 2018
* refactor custom op * fix * fix * fix * fix
yuxiangw
pushed a commit
to yuxiangw/incubator-mxnet
that referenced
this pull request
Jan 25, 2018
* refactor custom op * fix * fix * fix * fix
rahul003
pushed a commit
to rahul003/mxnet
that referenced
this pull request
Jun 4, 2018
* refactor custom op * fix * fix * fix * fix
zheng-da
pushed a commit
to zheng-da/incubator-mxnet
that referenced
this pull request
Jun 28, 2018
* refactor custom op * fix * fix * fix * fix
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(Brief description on what this PR is about)
Checklist
Essentials
make lint)Changes
Comments