Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[master] Make warning message when oneDNN is turned off less confusing #20700

Merged
merged 3 commits into from
Oct 30, 2021
Merged

[master] Make warning message when oneDNN is turned off less confusing #20700

merged 3 commits into from
Oct 30, 2021

Conversation

bartekkuncer
Copy link
Contributor

@bartekkuncer bartekkuncer commented Oct 25, 2021 •
edited
Loading

Description

Fixes #18019.

bartekkuncer and others added 2 commits October 25, 2021 15:27
@bartekkuncer @akarbown
Make warning message when oneDNN is turned off less confusing
35ac049 
Co-authored-by: Anna, Karbownik <anna.karbownik@intel.com>
@bartekkuncer
Apply clang-format
ba74017
@mxnet-bot
Copy link

Hey @bartekkuncer , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [sanity, windows-cpu, website, centos-gpu, unix-cpu, clang, miscellaneous, edge, windows-gpu, unix-gpu, centos-cpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@bartekkuncer bartekkuncer changed the title Warning [master] Make warning message when oneDNN is turned off less confusing Oct 25, 2021
@mseth10 mseth10 added the pr-work-in-progress PR is still work in progress label Oct 25, 2021
@bartekkuncer
Copy link
Contributor Author

@anko-intel What do you think?

@bartekkuncer bartekkuncer reopened this Oct 26, 2021
@bartekkuncer bartekkuncer marked this pull request as ready for review October 26, 2021 08:44
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 26, 2021
@bartekkuncer
Copy link
Contributor Author

@mxnet-bot run ci [unix-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-cpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 26, 2021
@bartekkuncer
Copy link
Contributor Author

@szha Please help with the merge.

@szha szha merged commit 54ca02a into apache:master Oct 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@anko-intel anko-intel anko-intel approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Confusing warning message when mkldnn is turned off
5 participants
@bartekkuncer @mxnet-bot @anko-intel @szha @mseth10