Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[BUGFIX] Fix (de)conv #20597

Merged
merged 2 commits into from
Sep 22, 2021
Merged

[BUGFIX] Fix (de)conv #20597

merged 2 commits into from
Sep 22, 2021

Conversation

barry-jin
Copy link
Contributor

Description

Update assert in convolution and deconvolution operators.

Reference: #20292 (comment)

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@barry-jin barry-jin requested a review from szha as a code owner September 21, 2021 00:53
@mxnet-bot
Copy link

Hey @barry-jin , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [miscellaneous, centos-cpu, windows-cpu, unix-gpu, edge, sanity, clang, windows-gpu, centos-gpu, unix-cpu, website]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Sep 21, 2021
@PawelGlomski-Intel
Copy link
Contributor

@akarbown can you please merge this?

@akarbown akarbown merged commit 0f5ba51 into apache:master Sep 22, 2021
@barry-jin barry-jin deleted the fix-assert branch September 23, 2021 14:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@szha szha Awaiting requested review from szha szha is a code owner

1 more reviewer

@akarbown akarbown akarbown approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@barry-jin @mxnet-bot @PawelGlomski-Intel @akarbown @mseth10