Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Auto-formatter to keep the same coding style #20356

Merged
merged 8 commits into from
Jul 16, 2021
Merged

Auto-formatter to keep the same coding style #20356

merged 8 commits into from
Jul 16, 2021

Conversation

mozga-intel
Copy link
Contributor

@mozga-intel mozga-intel commented Jun 16, 2021 •
edited
Loading

Description

This pull-request contains changes associated with a coding style.
Contains:

  1. src/operator/nn/mkldnn/
  2. include/mxnet/ndarray.h
  3. src/ndarray/ndarray.cc
  4. src/operator/operator_common.h
  5. src/operator/quantization/mkldnn/
  6. src/operator/subgraph/mkldnn/
  7. src/operator/tensor/amp_cast.cc
  8. src/operator/tensor/cast_storage-inl.h
  9. tests/cpp/include/test_mkldnn.h
  10. tests/cpp/operator/mkldnn_operator_test

.clang-format file:

---
Language: Cpp
BasedOnStyle: Google
ColumnLimit: 100
#AlignAfterOpenBracket: AlwaysBreak
AlignConsecutiveAssignments: true
AlignConsecutiveDeclarations: false
AlignConsecutiveMacros: true
DerivePointerAlignment: false
SortIncludes: true
MaxEmptyLinesToKeep: 1
PointerAlignment: Left
AllowAllParametersOfDeclarationOnNextLine: false
AllowShortBlocksOnASingleLine: false
AllowShortCaseLabelsOnASingleLine: false
AllowShortFunctionsOnASingleLine: Empty
AllowShortIfStatementsOnASingleLine: false
AllowShortLoopsOnASingleLine: false
AlwaysBreakAfterReturnType: None
AlwaysBreakBeforeMultilineStrings: true
AlwaysBreakTemplateDeclarations: true
BinPackArguments: false
BinPackParameters: false

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@mxnet-bot
Copy link

Hey @mozga-intel , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [miscellaneous, centos-gpu, website, clang, unix-gpu, windows-gpu, sanity, unix-cpu, edge, windows-cpu, centos-cpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Jun 16, 2021
@mozga-intel
Copy link
Contributor Author

@mxnet-bot run ci [unix-cpu, centos-cpu, unix-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [centos-cpu, unix-gpu, unix-cpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jun 16, 2021
@mozga-intel
Copy link
Contributor Author

@mxnet-bot run ci [unix-cpu, centos-cpu, unix-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [centos-cpu, unix-cpu, unix-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jun 17, 2021
anko-intel
anko-intel reviewed Jun 17, 2021
View reviewed changes
@mozga-intel mozga-intel force-pushed the mozga-intel/coding_style_google_formatter branch from 6884eba to 69ca096 Compare June 18, 2021 08:50
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Jun 18, 2021
@mseth10 mseth10 added pr-awaiting-review PR is waiting for code review pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-awaiting-review PR is waiting for code review labels Jul 12, 2021
@mozga-intel
Copy link
Contributor Author

@sfraczek Yes, please have a look at the description: a few things were added such as BinPackArguments/Params...

@mseth10 mseth10 added pr-awaiting-review PR is waiting for code review pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review labels Jul 13, 2021
@mozga-intel
Copy link
Contributor Author

@mxnet-bot run ci [unix-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-gpu]

@mozga-intel mozga-intel force-pushed the mozga-intel/coding_style_google_formatter branch from a274ffa to cd48d21 Compare July 14, 2021 08:41
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jul 14, 2021
@szha szha merged commit 0ae1f0c into apache:v1.x Jul 16, 2021
@RafLit RafLit mentioned this pull request Jul 20, 2021
Closed
@mozga-intel mozga-intel mentioned this pull request Jul 28, 2021
Merged
6 tasks
@mozga-intel mozga-intel mentioned this pull request Sep 8, 2021
Merged
6 tasks
@mozga-intel mozga-intel mentioned this pull request Oct 20, 2021
Merged
6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anirudh2290 anirudh2290 Awaiting requested review from anirudh2290 anirudh2290 is a code owner

@eric-haibin-lin eric-haibin-lin Awaiting requested review from eric-haibin-lin eric-haibin-lin is a code owner

2 more reviewers

@anko-intel anko-intel anko-intel left review comments

@sfraczek sfraczek sfraczek approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mozga-intel @mxnet-bot @anko-intel @szha @sfraczek @mseth10