Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[v1.x] Onnx Reshpe support for special caes #19804

Merged
merged 3 commits into from
Feb 2, 2021
Merged

[v1.x] Onnx Reshpe support for special caes #19804

merged 3 commits into from
Feb 2, 2021

Conversation

Zha0q1
Copy link
Contributor

@Zha0q1 Zha0q1 commented Jan 30, 2021

In general we do not support -2 -3 -4 in the target shape, but there are some special cases that we can convert to supported cases (only positive values, 0 and -1 in the target shape).

This helps us export a bunch of cv models in the gluon-cv model zoo

@Zha0q1 Zha0q1 requested a review from szha as a code owner January 30, 2021 00:28
@mxnet-bot
Copy link

Hey @Zha0q1 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [centos-gpu, sanity, miscellaneous, unix-gpu, edge, windows-cpu, centos-cpu, clang, unix-cpu, website, windows-gpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added the pr-awaiting-testing PR is reviewed and waiting CI build and test label Jan 30, 2021
waytrue17
waytrue17 reviewed Jan 30, 2021
View reviewed changes
python/mxnet/contrib/onnx/mx2onnx/_op_translations.py Outdated
# In general -2, -3, -4 in the target shape are not supoorted, but there are
# a few special cases that we can convert to supported scenarios

# If -2 and -4 are not used, then we can just remove the -4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this be -2 and -3 are not used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes! fixed

@lanking520 lanking520 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jan 30, 2021
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jan 30, 2021
josephevans
josephevans approved these changes Feb 2, 2021
View reviewed changes
Copy link
Contributor

@josephevans josephevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

waytrue17
waytrue17 approved these changes Feb 2, 2021
View reviewed changes
Copy link
Contributor

@waytrue17 waytrue17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Zha0q1 Zha0q1 merged commit 787416b into apache:v1.x Feb 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@szha szha Awaiting requested review from szha szha is a code owner

2 more reviewers

@josephevans josephevans josephevans approved these changes

@waytrue17 waytrue17 waytrue17 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Zha0q1 @mxnet-bot @josephevans @waytrue17 @lanking520