Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[RFC] [Licensing] Address ASF Feedback for 1.9.0.rc7 release #20616

@josephevans

Description

@josephevans

Problem statement

Based on the feedback from ASF on our vote to release MXNet v1.9.0.rc7, we still have a few licensing issues that caused a -1 vote, which prevents us from moving forward with the release.

Based on the RC7 voting thread, the following licensing issues are still outstanding:

  • Files incorrectly have ASF headers. These files are all copyrighted by NumPy developers and released under the 3-clause BSD license. We should not have added the ASF header and kept the original license headers intact, and mention this by including it in the "3-clause BSD license" section in LICENSE.

    • src/operator/numpy/np_einsum_op.cc
    • src/operator/numpy/np_einsum_op-inl.h
    • src/operator/numpy/np_einsum_path_op-inl.h
  • Some files are not correctly listed in LICENSE. For example, these files contain a "Copyright Microsoft" line but are released under ASF-2 or MIT license. These need to be properly mentioned in LICENSE:

    • src/operator/contrib/deformable_psroi_pooling.cu
    • src/operator/contrib/deformable_psroi_pooling-inl.h
    • src/operator/contrib/deformable_psroi_pooling.cc
    • src/operator/contrib/multi_proposal-inl.h
    • src/operator/contrib/multi_proposal.cc
    • src/operator/contrib/multi_proposal.cu
    • src/operator/contrib/psroi_pooling.cc
    • src/operator/contrib/psroi_pooling.cu
    • Additional files in the same situation as above (identified by running skywalking-eyes):
    • src/operator/contrib/psroi_pooling-inl.h
    • src/operator/contrib/deformable_convolution-inl.h
    • src/operator/contrib/deformable_convolution.cc
    • src/operator/contrib/deformable_convolution.cu

As ASF noted, not all files were checked and there could be others that are missed. In order to better identify licensing issues in the future, we should extend the use of automated tools (such as skywalking-eyes).

References

Metadata

Metadata

Assignees

No one assigned

    Labels

    LicensesRFCPost requesting for comments

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions