[MNG-8674] Deprecate mergeId in the Maven 3 model and remove it in the new model #2233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elharo
requested changes
Apr 5, 2025
| <version>4.0.0+</version> | ||
| <code> | ||
| <![CDATA[ | ||
| @Deprecated |
There was a problem hiding this comment.
So these are new methods being added in a deprecated state? That's unusual.
There should be a Javadoc comment about them of some kind, perhaps just indicating that they should not be used at all.
And if they're deprecated because they're only for internal use, that's not really what deprecated is typically used for.
There was a problem hiding this comment.
I've added a bit of javadoc.
Those methods are not new, they are not explicitly added, because the switch above from <version>4.0.0+</version> to <version>4.0.0</version> effectively does not generate them anymore. So I added them for backward compatibility as no-op.
elharo
approved these changes
Apr 28, 2025
|
Resolve #9634 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA issue: MNG-8674