[MWRAPPER-158] Remove incorrect license header #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "This code is licensed to ASF" license header on the generated ./mvn/wrapper/maven-wrapper.properties file does not make sense. The file is the user's, not ASF's. It is generated as a convenience for the user. The file is logically part of the user's own code. We don't know what license that has, so adding a license header is bound to be wrong.
b1792c1 to
fda8ab1
Compare
|
CI pipeline currently blocked by MWRAPPER-159 |
|
I don't understand why the test failed. I've never seen this check before: |
elharo
reviewed
Jun 13, 2025
|
Resolve #323 |
1 similar comment
|
Resolve #323 |
gnodet
approved these changes
Jul 14, 2025
It's not true. A lot of projects do add the wrapper configuration in the source tree. |
I think rebasing on current master should work. Can you do that @lbruun ? |
Done! |
|
@gnodet Please assign appropriate label to PR according to the type of change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "This code is licensed to ASF" license header on the generated
./mvn/wrapper/maven-wrapper.propertiesfile does not make sense. The file is the user's, not ASF's. It is generated as a convenience for the user.The file is logically part of the user's own code. We don't know what license that has so adding a license header is bound to be wrong. Therefore removed completely.
I'm guessing the code comes from a time when the Plugin was only (meant to be) used internally in the Apache Maven
project. Then it would make sense.
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MWRAPPER-XXX] - Fixes bug in ApproximateQuantiles,where you replace
MWRAPPER-XXXwith the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verifyto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.