Skip to content

Add icon for JetBrains Toolbox #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2020
Merged

Add icon for JetBrains Toolbox #579

merged 1 commit into from
Apr 7, 2020

Conversation

vlsi
Copy link
Collaborator

@vlsi vlsi commented Apr 5, 2020 •
edited
Loading

I'm not sure there's a square JMeter icon, so I use JM.

Toolbox:
Toolbox

IDEA:

IDEA

IDEA Darcula:

IDEA Darcula

Any comments?

@ham1
Copy link
Contributor

ham1 commented Apr 5, 2020

Maybe worth compressing the png using https://tinypng.com/ for example?

@vlsi
Copy link
Collaborator Author

vlsi commented Apr 5, 2020

Which png do you mean?

@ham1
Copy link
Contributor

ham1 commented Apr 5, 2020

.idea/icon.png?

@vlsi vlsi mentioned this pull request Apr 5, 2020
Closed
@vlsi
Copy link
Collaborator Author

vlsi commented Apr 5, 2020

The dark M does not look great in dark themes (see the PR description).

@vlsi
Copy link
Collaborator Author

vlsi commented Apr 7, 2020

Dark icon can be configured as .icon/icon_dark.png

@vlsi vlsi merged commit dd41e0f into apache:master Apr 7, 2020
@snuyanzin snuyanzin mentioned this pull request Oct 27, 2022
Merged
@vlsi vlsi mentioned this pull request May 11, 2023
Closed
@snuyanzin snuyanzin mentioned this pull request Aug 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@ham1 ham1 ham1 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vlsi @ham1