Skip to content

[IOTDB-6300] Support place time column at any column index in insert statement #12074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 28, 2024
Merged

[IOTDB-6300] Support place time column at any column index in insert statement #12074

merged 4 commits into from
Feb 28, 2024

Conversation

JackieTien97
Copy link
Contributor

In this pr, we enhance the insert statement in two cases:

  1. time column can be placed at any index of the column list:
insert into root.db.d1(s1,s2,time) values(1,2,3);
  1. we can add `` in time column:
insert into root.db.d1(`time`,s1,s2) values(1,2,3);

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

liuminghui233
liuminghui233 approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@liuminghui233 liuminghui233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :-)

@JackieTien97 JackieTien97 merged commit 086445c into master Feb 28, 2024
@JackieTien97 JackieTien97 deleted the ty/insertTime branch February 28, 2024 00:38
@HTHou HTHou mentioned this pull request Feb 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liuminghui233 liuminghui233 liuminghui233 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JackieTien97 @liuminghui233