Fix Go module name: add /v2 suffix #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuwenwei
approved these changes
Jun 18, 2025
|
Some files are generated by thrift and the Makefile(https://github.com/apache/iotdb-client-go/blob/main/Makefile) also needs to be modified. |
Signed-off-by: divinerapier <sihao.fang@outlook.com>
|
PTAL, Makefile was updated and e2e test is ok. Thanks. |
shuwenwei
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Updated the go.mod file to include the /v2 suffix in the module path, following Go Modules versioning requirements (i.e., module github.com/apache/iotdb-client-go/v2).
This change ensures that users can correctly fetch v2+ versions using go get github.com/apache/iotdb-client-go/v2, and prevents dependency issues caused by an incorrect module path.
Fix #131
Motivation
According to Go Modules best practices, when the major version is v2 or higher, the module path must include the /v2 suffix. Omitting this leads to problems with dependency management and import resolution.
With this fix, users can properly import and upgrade to v2+ versions of the SDK as recommended by the Go team.
Impact
This change only affects the go.mod file and import paths; there are no functional code changes.
Downstream users depending on v2+ of this project will need to update their import paths to github.com/apache/iotdb-client-go/v2.
References
Go Modules: Version Numbers