[#2424] improvement(spark-connector): make all Spark SQL keywords uppercase for consistency #2437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FANNG1
reviewed
Mar 5, 2024
integration-test/src/test/java/com/datastrato/gravitino/integration/test/spark/SparkIT.java
Show resolved
Hide resolved
|
LGTM, let's wait CI to finish. |
FANNG1
approved these changes
Mar 5, 2024
|
@ichuniq merged to main, welcome to join the Gravitino community, and hope to enjoy the journey! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Make all Spark SQL keywords used in spark connector integration test uppercase
Why are the changes needed?
Fix: #2424
Does this PR introduce any user-facing change?
No
How was this patch tested?
./gradlew build -PskipTests