[#17] feat(build): refactor the gradle script to consolidate the dependecy and plugin version #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xunliu please help to review this. |
xunliu
approved these changes
May 17, 2023
There was a problem hiding this comment.
I fork jerryshao:issue-17 to local, Build successful!
./gradlew build
Invalid Java installation found at '/Users/liuxun/Netease/jdk-11.0.12.jdk/Contents/Home' (Maven Toolchains). It will be re-checked in the next build. This might have performance impact if it keeps failing. Run the 'javaToolchains' task for more details.
<======-------> 52% EXECUTING [1m 52s]
> :schema:generateProto > Resolve files of :schema:protobufToolsLocator_protoc > protoc-3.17.3-osx-x86_64.exe > 1 MiB/11.9 MiB downloaded
> IDLE
^C% liuxun@MacBook-Pro unified-catalog %
liuxun@MacBook-Pro unified-catalog %
liuxun@MacBook-Pro unified-catalog %
liuxun@MacBook-Pro unified-catalog %
liuxun@MacBook-Pro unified-catalog % ./gradlew build
Starting a Gradle Daemon (subsequent builds will be faster)
BUILD SUCCESSFUL in 8m 6s
16 actionable tasks: 6 executed, 1 from cache, 9 up-to-date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR improves the gradle build file to use gradle catalog mechanism to centralize the dependency and plugin versions. Also removes some redundant codes.
Why are the changes needed?
Currently there's no centralized version control place for project, this will easily lead to dependency chaos. After some investigation, we choose to use gradle's default catalog mechanism to manage all the versions in a central place.
Fix: #17
Does this PR introduce any user-facing change?
NA
How was this patch tested?
Local manual test.