Skip to content

[#738]:Dependencies follow alphabetical order #1703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
Feb 11, 2024
Merged

[#738]:Dependencies follow alphabetical order #1703

merged 32 commits into from
Feb 11, 2024

Conversation

hiirrxnn
Copy link
Contributor

What changes were proposed in this pull request?

Dependencies follow alphabetical order

Why are the changes needed?

For better readability
Fix: #738

Does this PR introduce any user-facing change?

N/A

How was this patch tested?

N/A

@hiirrxnn
Copy link
Contributor Author

Please take a look , if this looks good , I will do the same for all subsequent build.gradle.kts files . This is just a demo.

@justinmclean
Copy link
Member

you need to run ./gradlew :catalogs:catalog-lakehouse-iceberg:spotlessApply to fix a formatting issue.

@justinmclean
Copy link
Member

Look good, but I think you may have moved a little too much around. It's just the content inside the dependencies block that needs to change.

@hiirrxnn
Copy link
Contributor Author

hiirrxnn commented Jan 25, 2024 •
edited
Loading

Look good, but I think you may have moved a little too much around. It's just the content inside the dependencies block that needs to change.

Could you mark in the files changed where I changed something I shouldn't have ,so that its clear. Should I not rearrange the 'exclude(xx)' dependencies.

jerryshao
jerryshao reviewed Jan 26, 2024
View reviewed changes
catalogs/catalog-lakehouse-iceberg/build.gradle.kts Outdated
Comment on lines 28 to 30
implementation(project(":api"))
implementation(project(":common"))
implementation(project(":core"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are always on the top.

@hiirrxnn
CI fix
0d094f0
@hiirrxnn
Merge branch 'main' of https://github.com/datastrato/gravitino into D…
5279faa 
…ependSort

ines starting with '#' will be ignored, and an empty message aborts
@yuqi1129
Copy link
Contributor

@hiirrxnn Do you need help? I suggest you run "./gradlew build -DskipTests -DskipITs" before pushing code to GitHub to ensure everything is OK locally.

@hiirrxnn
Copy link
Contributor Author

I have run the said command in check details but the issue persists.

@yuqi1129
Copy link
Contributor

@hiirrxnn
You still have some fomat issues. can you provide your local environment:

  • IDE you use and related-configuration like space and tabs as follows
image
  • JDK version
  • Local OS
  • and so on.

@hiirrxnn
Copy link
Contributor Author

I'm currently using VS Code IDE , JDK version : openjdk version "17.0.6" 2023-01-17
OpenJDK Runtime Environment Temurin-17.0.6+10 (build 17.0.6+10)
OpenJDK 64-Bit Server VM Temurin-17.0.6+10 (build 17.0.6+10, mixed mode) , and MacOS Sonoma 14.2.1 operating system

@hiirrxnn
Copy link
Contributor Author

This push is a draft , I will review it if any CI fails.

@justinmclean
Copy link
Member

You need to run ./gradlew :core:spotlessKotlinGradleCheck

@hiirrxnn
Copy link
Contributor Author

hiirrxnn commented Feb 2, 2024 •
edited
Loading

CI is still failing .Could you help me pinpoint which specific files are causing the problem ?

@justinmclean
Copy link
Member

If you look at the details you'll see it will tell you where it is failing in this case, you need to run ./gradlew :server:spotlessApply, running ./gradlew build -x test locally would also give you the same error, so it's best to do that first before pushing your changes.

@yuqi1129
Copy link
Contributor

yuqi1129 commented Feb 2, 2024

CI is still failing .Could you help me pinpoint which specific files are causing the problem ?

Here is the patch. Please take a look.
patch.txt

@hiirrxnn
CI
34aacab
@hiirrxnn
Merge branch 'main' of https://github.com/datastrato/gravitino into D…
7c3a0f8 
…ependSort

 Please enter a commit message to explain why this merge is necessary,
asda
@jerryshao
Copy link
Contributor

Thanks @hiirrxnn for the PR. @yuqi1129 @qqqttt123 do you have further comments?

@yuqi1129
Copy link
Contributor

yuqi1129 commented Feb 4, 2024

Thanks @hiirrxnn for the PR. @yuqi1129 @qqqttt123 do you have further comments?

I'm okay with the changes.

@hiirrxnn
Copy link
Contributor Author

hiirrxnn commented Feb 4, 2024

I still have one file remaining to sort , since because of it CI was failing , I pushed it untouched and will edit it once you guys approve the current changes Let me know if there are other improvements to be made.

@yuqi1129
Copy link
Contributor

yuqi1129 commented Feb 4, 2024

I still have one file remaining to sort , since because of it CI was failing , I pushed it untouched and will edit it once you guys approve the current changes Let me know if there are other improvements to be made.

Hi, Is your local environment Windows? Can you help try this
#1976 (comment), Still we haven't tested the spotless plugin with Windows comprehensively

@hiirrxnn
Copy link
Contributor Author

hiirrxnn commented Feb 4, 2024

I'm sorry but I use MacOS.

@yuqi1129
Copy link
Contributor

yuqi1129 commented Feb 6, 2024

@hiirrxnn
Could you please resolve the conflicts?

@hiirrxnn
Copy link
Contributor Author

hiirrxnn commented Feb 6, 2024

Sure

yuqi1129
yuqi1129 reviewed Feb 7, 2024
View reviewed changes
api/build.gradle.kts Outdated
testRuntimeOnly(libs.junit.jupiter.engine)
testImplementation(libs.junit.jupiter.params)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we introduce a duplicated dependency libs.junit.jupiter.params?

integration-test/build.gradle.kts
testImplementation(libs.testcontainers)
testImplementation(libs.testcontainers.junit.jupiter)
testImplementation(libs.testcontainers.mysql)
testImplementation(libs.testcontainers.postgresql)
testImplementation(libs.trino.jdbc)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this is missing?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hiirrxnn
Please undo the changes and resolve any conflicts.

yuqi1129
yuqi1129 approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@yuqi1129 yuqi1129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM, @qqqttt123 do you have any further comments?

@yuqi1129 yuqi1129 merged commit fbcd416 into apache:main Feb 11, 2024
@yuqi1129
Copy link
Contributor

@hiirrxnn
Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerryshao jerryshao jerryshao left review comments

@yuqi1129 yuqi1129 yuqi1129 approved these changes

+1 more reviewer

@qqqttt123 qqqttt123 qqqttt123 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Improvement] Dependencies follow the alphabet order
5 participants
@hiirrxnn @justinmclean @yuqi1129 @jerryshao @qqqttt123