[#165]fix: Rethrow real exception when transaction fails #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Coverage Report
Files
|
yuqi1129
reviewed
Aug 3, 2023
core/src/main/java/com/datastrato/graviton/storage/kv/RocksDBKvBackend.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/datastrato/graviton/storage/kv/RocksDBKvBackend.java
Outdated
Show resolved
Hide resolved
|
@yuqi1129 please help to review this pr. |
|
LGTM |
yuqi1129
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR rethrow the real exception when function fails in transaction
Why are the changes needed?
Transaction caller needs to handle the real exception
Fix: #165
Does this PR introduce any user-facing change?
Transaction caller should handle the exception which generated by
ExecutableHow was this patch tested?
UT modified.