[#12] feat(schema): Implement the schema metadata and type system #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xunliu
reviewed
May 16, 2023
| Field.required("audit_info", AuditInfo.class, "The audit info of the lakehouse"); | ||
|
|
||
| @JsonProperty("id") | ||
| private Long id; |
There was a problem hiding this comment.
Does this Long type, whether need to be unified to Int(or Long) like other schema types?
There was a problem hiding this comment.
I don't have strong feelings about using the same type or not. My original thinking is that there might not be so many entities for some types like "tenant" in one database, using integer should be enough.
| public class Lakehouse implements Entity, Auditable { | ||
|
|
||
| public static final Field ID = | ||
| Field.required("id", Long.class, "The unique identifier of the lakehouse"); |
There was a problem hiding this comment.
Does this Long.class type, whether need to be unified to Int.class like other schema ID? For example Tenant.ID.
xunliu
previously approved these changes
May 17, 2023
|
@xunliu PTAL, thanks. |
xunliu
reviewed
May 18, 2023
There was a problem hiding this comment.
LGTM.
./gradlew build
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 62076 100 62076 0 0 83773 0 --:--:-- --:--:-- --:--:-- 83660
Starting a Gradle Daemon, 1 incompatible Daemon could not be reused, use --status for details
BUILD SUCCESSFUL in 39s
22 actionable tasks: 20 executed, 1 from cache, 1 up-to-date
xunliu
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to implement the schema metadata and type system in Java and Protobuf.
Why are the changes needed?
This PR defines a core metadata system for unified catalog.
Does this PR introduce any user-facing change?
NA
How was this patch tested?
This PR adds UT to cover the schema definitions.