Skip to content

Conversation

jerryshao
Copy link
Contributor

What changes were proposed in this pull request?

Fix the failed 'drop catalog' test on Trino image gravitino-ci-trino:0.1.3.
Trino image gravitino-ci-trino:0.1.2 use the gravitino-trino-connector-0.3.0-SNAPSHOT.jar, it does not support drop catalog, so the tester has made it compatible with this.
Trino image gravitino-ci-trino:0.1.3 use the gravitino-trino-connector-0.4.0-SNAPSHOT.jar, it support drop catalog.
the test did not pass.

Why are the changes needed?

Fix: #1328

Does this PR introduce any user-facing change?

NO

How was this patch tested?

NO

…rino image gravitino-ci-trino:0.1.3. (#1329)

### What changes were proposed in this pull request?

Fix the failed 'drop catalog' test on Trino image
gravitino-ci-trino:0.1.3.
Trino image gravitino-ci-trino:0.1.2 use the
gravitino-trino-connector-0.3.0-SNAPSHOT.jar, it does not support drop
catalog, so the tester has made it compatible with this.
Trino image gravitino-ci-trino:0.1.3 use the
gravitino-trino-connector-0.4.0-SNAPSHOT.jar, it support drop catalog.
 the test did not pass. 

### Why are the changes needed?

Fix: #1328

### Does this PR introduce _any_ user-facing change?

NO

### How was this patch tested?

NO
@jerryshao jerryshao added cherry-pick need backport Issues that need to backport to another branch labels Jan 5, 2024
@jerryshao
Copy link
Contributor Author

@diqiu50 please check the ci issue, thanks.

Copy link

github-actions bot commented Jan 5, 2024

Code Coverage Report

Overall Project 66.02% 🟢

There is no coverage information present for the Files changed

Copy link
Contributor

@yuqi1129 yuqi1129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's OK for me.

@diqiu50 diqiu50 merged commit c38440f into branch-0.3 Jan 5, 2024
@yuqi1129 yuqi1129 deleted the cherry-pick-branch-0.3-26731a9ddad3979358354167e71337eaafd0c7ae branch January 9, 2024 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick need backport Issues that need to backport to another branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants