-
Notifications
You must be signed in to change notification settings - Fork 594
[#554] improvement(CI-Hive): improve Hadoop access permission #1194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR, based on #620, adds owner validation for #620 (review). @xunliu Please review it again, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
||
HADOOP_PACKAGE_NAME="hadoop-${HADOOP_VERSION}.tar.gz" # Must export this variable for Dockerfile | ||
HADOOP_DOWNLOAD_URL="http://archive.apache.org/dist/hadoop/core/hadoop-${HADOOP_VERSION}/${HADOOP_PACKAGE_NAME}" | ||
|
||
HIVE_PACKAGE_NAME="apache-hive-${HIVE_VERSION}-bin.tar.gz" # Must export this variable for Dockerfile | ||
HIVE_DOWNLOAD_URL="https://archive.apache.org/dist/hive/hive-${HIVE_VERSION}/${HIVE_PACKAGE_NAME}" | ||
|
||
JDBC_DIVER_PACKAGE_NAME="mysql-connector-java-${MYSQL_JDBC_DRIVER_VERSION}.tar.gz" # Must export this variable for Dockerfile | ||
JDBC_DIVER_DOWNLOAD_URL="https://downloads.mysql.com/archives/get/p/3/file/${JDBC_DIVER_PACKAGE_NAME}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you use this version? We used another version in JDBC integration tests and playground.
https://repo1.maven.org/maven2/mysql/mysql-connector-java/8.0.27/mysql-connector-java-8.0.27.jar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have been using this version from the beginning(see following ref) in Hive-CI-Docker, but the JDBC integration tests and the playground introduced later are inconsistent with the previous version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, we don't need to keep consistent in this pr. I guess we can change them to a consistent version in later pr.
Will you raise a follow-up pr to modify the Docker image which integration-test uses and the document? |
The Docker image The document also modified in this PR(see file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Do you also need to ship a new hive image for users? cc @qqqttt123 |
No. This image is used by developers. |
What changes were proposed in this pull request?
hdfs
as HDFS superuser group in containerdatastrato
as the Hive catalog Integration Test user instead ofroot
Why are the changes needed?
we should not use the
root
user directly to access HDFSFix: #554
Does this PR introduce any user-facing change?
no
How was this patch tested?
existing ITs