[#8382]Improvement(IcebergHiveCachedClientPool): prevent NPE in IcebergHiveCachedClientPool when closing multiple instances #8460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rgHiveCachedClientPool when closing multiple instances (#8455) <!-- 1. Title: [#<issue>] <type>(<scope>): <subject> Examples: - "[#123] feat(operator): support xxx" - "[#233] fix: check null before access result in xxx" - "[MINOR] refactor: fix typo in variable name" - "[MINOR] docs: fix typo in README" - "[#255] test: fix flaky test NameOfTheTest" Reference: https://www.conventionalcommits.org/en/v1.0.0/ 2. If the PR is unfinished, please mark this PR as draft. --> ### What changes were proposed in this pull request? Add a null check before shutting down scheduledExecutorService in close method. ### Why are the changes needed? clientPoolCache is a static field, meaning it is shared across all instances of IcebergHiveCachedClientPool. Only the first instance that calls init() will initialize both clientPoolCache and scheduledExecutorService. Any subsequent instances will find clientPoolCache already initialized, so they will not initialize scheduledExecutorService (it remains null for those instances).When we create multiple instances of IcebergHiveCachedClientPool, only the first instance will have a non-null scheduledExecutorService.The other instances will have scheduledExecutorService as null. When we call close() on all instances, each will attempt to call scheduledExecutorService.shutdownNow() For instances where scheduledExecutorService is null, this results in a NullPointerException. Fix: (#8382 ) ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? unit testing
yuqi1129
approved these changes
Sep 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add a null check before shutting down scheduledExecutorService in close method.
Why are the changes needed?
clientPoolCache is a static field, meaning it is shared across all instances of IcebergHiveCachedClientPool.
Only the first instance that calls init() will initialize both clientPoolCache and scheduledExecutorService.
Any subsequent instances will find clientPoolCache already initialized, so they will not initialize scheduledExecutorService (it remains null for those instances).When we create multiple instances of IcebergHiveCachedClientPool, only the first instance will have a non-null scheduledExecutorService.The other instances will have scheduledExecutorService as null.
When we call close() on all instances, each will attempt to call scheduledExecutorService.shutdownNow()
For instances where scheduledExecutorService is null, this results in a NullPointerException.
Fix: (#8382 )
Does this PR introduce any user-facing change?
No
How was this patch tested?
unit testing