Skip to content

[#8110] Improvement: Equality check in equals method in FileSetCatalogOperations.java #8132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 18, 2025
Merged

[#8110] Improvement: Equality check in equals method in FileSetCatalogOperations.java #8132

merged 2 commits into from
Aug 18, 2025

Conversation

Raj-G07
Copy link
Contributor

@Raj-G07 Raj-G07 commented Aug 16, 2025 •
edited
Loading

What changes were proposed in this pull request?

  • Fixed a bug in the equals method where scheme was incorrectly compared to that.authority.
  • Updated the logic to correctly compare scheme with that.scheme

Why are the changes needed?

This fix ensures object equality is consistent and accurate.

Fix: #8110

Does this PR introduce any user-facing change?

  • No user-facing changes.
  • This fix only corrects the internal equality logic.

How was this patch tested?

Verified that objects with different scheme values are not considered equal.

@Raj-G07 Raj-G07 mentioned this pull request Aug 17, 2025
Closed
@jerryshao jerryshao requested review from yuqi1129 and mchades August 18, 2025 02:11
mchades
mchades reviewed Aug 18, 2025
View reviewed changes
Copy link
Contributor

@mchades mchades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. @yuqi1129 Please also take a look.

@Raj-G07 Please update the PR title and description to follow the template.

@yuqi1129
Copy link
Contributor

LGTM

@Raj-G07
Please change the title and description of the PR, if you have any problems, you can refer to those of other PRs. Thanks

@Raj-G07 Raj-G07 changed the title Imp/filesetCatalogOperations [#8110] Improvement: Equality check in equals method in FileSetCatalogOperations.java Aug 18, 2025
@Raj-G07 Raj-G07 requested a review from mchades August 18, 2025 04:42
@yuqi1129 yuqi1129 merged commit 8aff98d into apache:main Aug 18, 2025
29 checks passed
@yuqi1129 yuqi1129 added the 1.0.0 Release v1.0.0 label Aug 18, 2025
@mchades mchades removed the 1.0.0 Release v1.0.0 label Aug 18, 2025
@Raj-G07 Raj-G07 deleted the imp/filesetCatalogOperations branch August 18, 2025 07:42
@Raj-G07
Copy link
Contributor Author

Raj-G07 commented Aug 18, 2025

Thanks for reviewing and merging it!

@yuqi1129 yuqi1129 added the 1.0.0 Release v1.0.0 label Aug 18, 2025
@mchades mchades removed the 1.0.0 Release v1.0.0 label Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuqi1129 yuqi1129 yuqi1129 approved these changes

@mchades mchades Awaiting requested review from mchades

Assignees

@Raj-G07 Raj-G07

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Improvement] Error in equals in FilesetCatalogOperations.java
3 participants
@Raj-G07 @yuqi1129 @mchades