-
Notifications
You must be signed in to change notification settings - Fork 596
Closed
Labels
0.9.1Release v0.9.1Release v0.9.11.0.0Release v1.0.0Release v1.0.0good first issueGood for newcomersGood for newcomersimprovementImprovements on everythingImprovements on everything
Description
What would you like to be improved?
Add these tests to TestNamespace causes test failures:
@Test
public void testFromString() {
Assertions.assertEquals(Namespace.empty(), Namespace.fromString(""));
Assertions.assertEquals(Namespace.of("a", "b"), Namespace.fromString("a.b"));
Assertions.assertEquals(Namespace.of("a"), Namespace.fromString("a"));
}
@Test
public void testFromStringInvalidArgs() {
Assertions.assertThrows(IllegalArgumentException.class, () -> Namespace.fromString(null));
Assertions.assertThrows(IllegalArgumentException.class, () -> Namespace.fromString(".a"));
Assertions.assertThrows(IllegalArgumentException.class, () -> Namespace.fromString("a."));
Assertions.assertThrows(IllegalArgumentException.class, () -> Namespace.fromString("a..b"));
}
How should we improve?
Fix fromString in Namespace.java so that the tests pass.
Metadata
Metadata
Assignees
Labels
0.9.1Release v0.9.1Release v0.9.11.0.0Release v1.0.0Release v1.0.0good first issueGood for newcomersGood for newcomersimprovementImprovements on everythingImprovements on everything