fix(radar): itemStyle of blur not working #21081
Conversation
|
Thanks for your contribution! |
|
Referring to the transparency setting of the line, then do you need to design it here, I think the actual meaning of the bug proposer is that the transparency of the line and the point is not consistent
卤蛋?
***@***.***
…------------------ 原始邮件 ------------------
发件人: "Wenli ***@***.***>;
发送时间: 2025年7月1日(星期二) 晚上6:38
收件人: ***@***.***>;
抄送: ***@***.***>; ***@***.***>;
主题: Re: [apache/echarts] fix: add symbolPath opacity. close #21074 (PR #21081)
@Ovilia requested changes on this pull request.
@Ovilia 请求对此拉取请求进行修改。
Why setting opacity to a fixed value? This bug should relates to blur state.
为何将透明度设为固定值？这个错误应该与 blur 状态有关。
—
Reply to this email directly, view it on GitHub, or unsubscribe.
直接回复此邮件，在 GitHub 上查看，或取消订阅。
You are receiving this because you authored the thread.
您收到此邮件是因为您是此讨论串的作者。 Message ID: ***@***.***>
|
bbed25a to
442ca03
Compare
|
Hello, I refer to the way you said.,Changed a version.,By the way, the original fixed way of the line was also deleted. |
|
@Ovilia Hello, it has been modified according to your comments and is waiting for your review |
There was a problem hiding this comment.
Sorry for the late reply. I think the overall direction is correct, and it can be simplified as line series does. And please add a test case in radar.html to test it.
442ca03 to
ce09c28
Compare
ce09c28 to
f19de05
Compare
|
@Ovilia Hello, I learned how to write the line series again, changed the version, and added test cases to the radar.html |
src/chart/radar/RadarView.ts
Outdated
| { | ||
| fill: 'none', | ||
| stroke: color | ||
| data.eachItemGraphicEl(function (itemGroup: graphic.Group, idx) { |
There was a problem hiding this comment.
Please don't change the indent if there's no problem with the old code. It makes the diff hard to review.
test/radar.html
Outdated
|
|
||
| require([ | ||
| 'echarts' | ||
| ], function (echarts) { | ||
|
|
There was a problem hiding this comment.
Again, please revert the changes of indent. If you are using auto-formatting tools, you may need to disable it.
f19de05 to
6e5a8a7
Compare
090ef70 to
872a819
Compare
f192b03 to
d0994b7
Compare
9eb243a to
61828de
Compare
61828de to
edc939e
Compare
|
Thanks for your contribution! |
|
Thank you for your review, I learned a lot, and I will continue to contribute in the future |
|
The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-21081@edc939e |
You are more than welcomed! I did a few changes in #21124 . You may add visual test changes in future PRs. |
fix(radar): improve logic and add test cases of #21081
|
@Ovilia Sorry to bother, why is there no list of contributors after my PR is merged? Also, the last fix, do you need to write some visual verification similar to before and after selection? |
|
@mustcanbedo Hi, this PR and your id are listed in the release note. Where do you mean that not listed? If you mean the contributor GitHub page, I believe it only list the most contributed ones, rather than a full list. |
Brief Information
This pull request is in the type of:
What does this PR do?
Fixed issues
#21074
Details
Before: What was the problem?
After: How does it behave after the fixing?
Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Others
Merging options
Other information