fix https://github.com/apache/dubbo/issues/13135 #13139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlbumenJ
reviewed
Sep 29, 2023
dubbo-cluster/pom.xml
Outdated
Comment on lines
95
to
99
| <dependency> | ||
| <groupId>org.openjdk.nashorn</groupId> | ||
| <artifactId>nashorn-core</artifactId> | ||
| <version>${nashorn-core.version}</version> | ||
| </dependency> |
There was a problem hiding this comment.
Test scope would be better. We should not import such engine by default.
There was a problem hiding this comment.
Okay, I'll change it to "testing".
|
@AlbumenJ process successful. |
|
Kudos, SonarCloud Quality Gate passed! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.2 #13139 +/- ##
============================================
+ Coverage 69.38% 69.40% +0.02%
Complexity 2 2
============================================
Files 1649 1649
Lines 68722 68724 +2
Branches 10012 10013 +1
============================================
+ Hits 47680 47699 +19
+ Misses 16462 16429 -33
- Partials 4580 4596 +16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AlbumenJ
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
add openjdk support javascript unit test jar pom
Brief changelog
Fix the problem of maven build interruption due to lack of js script parsing jar package
Verifying this change
build successful！
Checklist