Skip to content

Conversation

oxsean
Copy link
Contributor

@oxsean oxsean commented May 15, 2025

What is the purpose of the change?

  • Support custom SSE input through the class org.apache.dubbo.remoting.http12.message.ServerSentEvent
  • Rest skips parsing of StreamObserver type parameters

@codecov-commenter
Copy link

codecov-commenter commented May 15, 2025

Codecov Report

Attention: Patch coverage is 30.66667% with 52 lines in your changes missing coverage. Please review.

Project coverage is 60.71%. Comparing base (d6b11cf) to head (d4bad23).
Report is 9 commits behind head on 3.3.

Files with missing lines Patch % Lines
...dubbo/remoting/http12/message/ServerSentEvent.java 0.00% 25 Missing ⚠️
...emoting/http12/message/ServerSentEventEncoder.java 50.00% 18 Missing and 1 partial ⚠️
...i/rest/support/jaxrs/FallbackArgumentResolver.java 0.00% 2 Missing ⚠️
.../rest/support/spring/FallbackArgumentResolver.java 0.00% 1 Missing and 1 partial ⚠️
...l/tri/h12/http1/Http1SseServerChannelObserver.java 0.00% 2 Missing ⚠️
...i/rest/support/basic/FallbackArgumentResolver.java 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                3.3   #15387      +/-   ##
============================================
- Coverage     60.73%   60.71%   -0.02%     
- Complexity    10920    10927       +7     
============================================
  Files          1886     1887       +1     
  Lines         86162    86218      +56     
  Branches      12913    12923      +10     
============================================
+ Hits          52328    52351      +23     
- Misses        28374    28392      +18     
- Partials       5460     5475      +15     
Flag Coverage Δ
integration-tests 33.19% <0.00%> (+0.07%) ⬆️
samples-tests 29.32% <0.00%> (-0.04%) ⬇️
unit-tests 58.87% <30.66%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@oxsean oxsean force-pushed the triple-sse-enhance branch from 57ff8d7 to d4bad23 Compare May 15, 2025 08:52
@oxsean oxsean merged commit a37bc2c into apache:3.3 May 15, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants