Reorganize the dependency in dubbo-demo #15384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.3 #15384 +/- ##
============================================
+ Coverage 60.73% 60.75% +0.02%
+ Complexity 10920 10919 -1
============================================
Files 1886 1886
Lines 86162 86162
Branches 12913 12913
============================================
+ Hits 52328 52346 +18
+ Misses 28374 28345 -29
- Partials 5460 5471 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
oxsean
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change?
Currently, the dependencies in dubbo-demo are somewhat redundant—for example, even though Zookeeper is being used, the Nacos dependency is still included. The configuration files also contain unnecessary entries, such as qos = false. Additionally, there are some improper usage practices. We need to reorganize the project by keeping only the minimal required set, and improve the README.md documentation to lower the barrier for users to use and learn from the demo.
ref #15380
Checklist