Skip to content

[ISSUE #15377] The value of grpc-timeout may not comply with the specification #15378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 12, 2025
Merged

[ISSUE #15377] The value of grpc-timeout may not comply with the specification #15378

merged 2 commits into from
May 12, 2025

Conversation

cnzakii
Copy link
Member

@cnzakii cnzakii commented May 12, 2025

What is the purpose of the change?

See #15377

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@wcy666103
Copy link
Contributor

use mvn spotless:apply to format the code.

@codecov-commenter
Copy link

codecov-commenter commented May 12, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 38.88889% with 11 lines in your changes missing coverage. Please review.

Project coverage is 60.73%. Comparing base (84d8cc2) to head (db3fe96).
Report is 1 commits behind head on 3.3.

Files with missing lines Patch % Lines
...che/dubbo/rpc/protocol/tri/h12/grpc/GrpcUtils.java 35.29% 7 Missing and 4 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                3.3   #15378      +/-   ##
============================================
- Coverage     60.74%   60.73%   -0.02%     
- Complexity    10913    10920       +7     
============================================
  Files          1886     1886              
  Lines         86145    86162      +17     
  Branches      12906    12913       +7     
============================================
+ Hits          52331    52332       +1     
- Misses        28359    28374      +15     
- Partials       5455     5456       +1
Flag Coverage Δ
integration-tests 33.12% <38.88%> (-0.01%) ⬇️
samples-tests 29.37% <38.88%> (+0.01%) ⬆️
unit-tests 58.85% <27.77%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wcy666103 wcy666103 mentioned this pull request May 12, 2025
Merged
4 tasks
@AlbumenJ AlbumenJ merged commit d6b11cf into apache:3.3 May 12, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cnzakii @wcy666103 @codecov-commenter @AlbumenJ