Skip to content

[ISSUE#15326]: Remove duplicate checks <URLParam> #15327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2025
Merged

[ISSUE#15326]: Remove duplicate checks <URLParam> #15327

merged 1 commit into from
Apr 20, 2025

Conversation

cnzakii
Copy link
Member

@cnzakii cnzakii commented Apr 19, 2025

What is the purpose of the change?

See: #15326

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.76%. Comparing base (93cfa82) to head (0b3f5bb).
⚠️ Report is 142 commits behind head on 3.3.

Additional details and impacted files
@@             Coverage Diff              @@
##                3.3   #15327      +/-   ##
============================================
- Coverage     60.78%   60.76%   -0.02%     
+ Complexity    10923    10917       -6     
============================================
  Files          1886     1886              
  Lines         86129    86127       -2     
  Branches      12903    12903              
============================================
- Hits          52350    52335      -15     
- Misses        28322    28331       +9     
- Partials       5457     5461       +4     
Flag Coverage Δ
integration-tests 33.19% <0.00%> (-0.02%) ⬇️
samples-tests 29.35% <0.00%> (+0.09%) ⬆️
unit-tests 58.92% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AlbumenJ AlbumenJ merged commit e298731 into apache:3.3 Apr 20, 2025
19 checks passed
@aditya0yadav
Copy link

@cnzakii
Dear Mentor,
Could you please check your email when you get a chance? I'm currently facing an issue and would appreciate your guidance.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants