Skip to content

Optimize GitHub Action to Retrieve target/logs/ Files #15264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 20, 2025
Merged

Optimize GitHub Action to Retrieve target/logs/ Files #15264

merged 3 commits into from
Apr 20, 2025

Conversation

RainYuY
Copy link
Contributor

@RainYuY RainYuY commented Mar 22, 2025 •
edited
Loading

What is the purpose of the change?

upload artifacts for logs
This is a solution for issue #15234
After this PR, we can download runtime logs at step Upload test logs

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.76%. Comparing base (ab07a4b) to head (e03c906).
Report is 117 commits behind head on 3.3.

Additional details and impacted files 
@@            Coverage Diff            @@
##                3.3   #15264   +/-   ##
=========================================
  Coverage     60.75%   60.76%           
- Complexity    10915    10920    +5     
=========================================
  Files          1886     1886           
  Lines         86123    86123           
  Branches      12902    12902           
=========================================
+ Hits          52328    52336    +8     
+ Misses        28336    28325   -11     
- Partials       5459     5462    +3
Flag Coverage Δ
integration-tests 33.19% <ø> (+0.01%) ⬆️
samples-tests 29.34% <ø> (+<0.01%) ⬆️
unit-tests 58.90% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AlbumenJ
Copy link
Member

image

@RainYuY
Copy link
Contributor Author

RainYuY commented Mar 24, 2025

image

This PR need another PRs.
apache/dubbo-integration-cases#62
apache/dubbo-samples#1212

@RainYuY
Copy link
Contributor Author

RainYuY commented Apr 7, 2025

I think after apache/dubbo-samples#1214 be merged.This PR can be merged.
PTAL. @AlbumenJ

CrazyHZM
CrazyHZM approved these changes Apr 20, 2025
View reviewed changes
Copy link
Member

@CrazyHZM CrazyHZM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CrazyHZM CrazyHZM merged commit 7b34ad9 into apache:3.3 Apr 20, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CrazyHZM CrazyHZM CrazyHZM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RainYuY @codecov-commenter @AlbumenJ @CrazyHZM