Skip to content

fix provider get baggage error #15257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 24, 2025
Merged

fix provider get baggage error #15257

merged 3 commits into from
Mar 24, 2025
+1 −1

Conversation

songxiaosheng
Copy link
Member

@songxiaosheng songxiaosheng commented Mar 19, 2025 •
edited
Loading

What is the purpose of the change?

@AlbumenJ PATL
when we use String.valueOf it will be "null" then cause a exception

java.lang.ArrayIndexOutOfBoundsException: Index 1 out of bounds for length 1
	at io.micrometer.tracing.brave.bridge.W3CBaggagePropagator.addBaggageToContext(W3CPropagation.java:388) ~[micrometer-tracing-bridge-brave-1.0.5.jar:1.0.5]
	at io.micrometer.tracing.brave.bridge.W3CBaggagePropagator.contextWithBaggage(W3CPropagation.java:372) ~[micrometer-tracing-bridge-brave-1.0.5.jar:1.0.5]
	at io.micrometer.tracing.brave.bridge.W3CPropagation.withBaggage(W3CPropagation.java:273) ~[micrometer-tracing-bridge-brave-1.0.5.jar:1.0.5]
	at io.micrometer.tracing.brave.bridge.W3CPropagation.lambda$extractor$1(W3CPropagation.java:264) ~[micrometer-tracing-bridge-brave-1.0.5.jar:1.0.5]
	at io.micrometer.tracing.brave.bridge.BravePropagator.extract(BravePropagator.java:58) ~[micrometer-tracing-bridge-brave-1.0.5.jar:1.0.5]
	at io.micrometer.tracing.handler.PropagatingReceiverTracingObservationHandler.onStart(PropagatingReceiverTracingObservationHandler.java:58) ~[micrometer-tracing-1.0.5.jar:1.0.5]
	at

debug as follow
image

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.77%. Comparing base (4ce9c6f) to head (fe3a2b3).

Additional details and impacted files 
@@             Coverage Diff              @@
##                3.3   #15257      +/-   ##
============================================
- Coverage     60.78%   60.77%   -0.01%     
+ Complexity    10896    10886      -10     
============================================
  Files          1885     1885              
  Lines         86087    86087              
  Branches      12896    12896              
============================================
- Hits          52327    52319       -8     
- Misses        28312    28319       +7     
- Partials       5448     5449       +1
Flag Coverage Δ
integration-tests 33.08% <0.00%> (-0.04%) ⬇️
samples-tests 29.19% <0.00%> (-0.02%) ⬇️
unit-tests 58.90% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@songxiaosheng songxiaosheng requested a review from CrazyHZM March 20, 2025 14:31
@AlbumenJ AlbumenJ merged commit 62717d8 into apache:3.3 Mar 24, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlbumenJ AlbumenJ Awaiting requested review from AlbumenJ

@conghuhu conghuhu Awaiting requested review from conghuhu

@CrazyHZM CrazyHZM Awaiting requested review from CrazyHZM

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@songxiaosheng @codecov-commenter @AlbumenJ