Skip to content

Fix concurrency problem in ThreadlessExecutor #15210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 6, 2025
Merged

Fix concurrency problem in ThreadlessExecutor #15210

merged 1 commit into from
Mar 6, 2025

Conversation

finefuture
Copy link
Contributor

What is the purpose of the change?

execute -> LockSupport.unpark
shutdownNow -> waiter.set

When executing concurrently, ClassCastException may occur
image

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.77%. Comparing base (91b005e) to head (d6d9061).
Report is 160 commits behind head on 3.3.

Additional details and impacted files 
@@             Coverage Diff              @@
##                3.3   #15210      +/-   ##
============================================
+ Coverage     60.76%   60.77%   +0.01%     
+ Complexity    10886    10885       -1     
============================================
  Files          1885     1885              
  Lines         86071    86072       +1     
  Branches      12892    12892              
============================================
+ Hits          52298    52308      +10     
+ Misses        28326    28316      -10     
- Partials       5447     5448       +1
Flag Coverage Δ
integration-tests 33.14% <100.00%> (+0.05%) ⬆️
samples-tests 29.19% <66.66%> (+<0.01%) ⬆️
unit-tests 58.93% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

EarthChen
EarthChen approved these changes Mar 6, 2025
View reviewed changes
Copy link
Member

@EarthChen EarthChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EarthChen EarthChen merged commit 3e5216f into apache:3.3 Mar 6, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EarthChen EarthChen EarthChen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@finefuture @codecov-commenter @EarthChen