Skip to content

exclude logback transit dependency in zookeeper #15208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 6, 2025
Merged

exclude logback transit dependency in zookeeper #15208

merged 1 commit into from
Mar 6, 2025

Conversation

RainYuY
Copy link
Contributor

@RainYuY RainYuY commented Mar 5, 2025

What is the purpose of the change?

exclude logback transit dependency in zookeeper

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.40%. Comparing base (a9fedd5) to head (86be33c).
Report is 42 commits behind head on 3.2.

❗ There is a different number of reports uploaded between BASE (a9fedd5) and HEAD (86be33c). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (a9fedd5) HEAD (86be33c)
1 0
Additional details and impacted files 
@@              Coverage Diff              @@
##                3.2   #15208       +/-   ##
=============================================
- Coverage     70.16%   41.40%   -28.77%     
- Complexity        0    10513    +10513     
=============================================
  Files          1608     1652       +44     
  Lines         70239    71438     +1199     
  Branches      10123    10159       +36     
=============================================
- Hits          49282    29577    -19705     
- Misses        16310    37719    +21409     
+ Partials       4647     4142      -505
Flag Coverage Δ
integration-tests 38.33% <ø> (?)
samples-tests 36.36% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AlbumenJ AlbumenJ merged commit 8e4d116 into apache:3.2 Mar 6, 2025
19 checks passed
@RainYuY RainYuY mentioned this pull request Mar 6, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RainYuY @codecov-commenter @AlbumenJ