Skip to content

Remove duplicated invokers in registry notification #15060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 16, 2025
Merged

Remove duplicated invokers in registry notification #15060

merged 2 commits into from
May 16, 2025

Conversation

AlbumenJ
Copy link
Member

@AlbumenJ AlbumenJ commented Jan 16, 2025 •
edited
Loading

What is the purpose of the change?

Duplicated invokers will be created but ignored because we use map to store them

Thus, this will cause invoker nerver being destroyed

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@codecov-commenter
Copy link

codecov-commenter commented May 13, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 41.38%. Comparing base (fc5f066) to head (6a97d93).
Report is 3 commits behind head on 3.2.

Files with missing lines Patch % Lines
.../dubbo/registry/integration/RegistryDirectory.java 33.33% 3 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                3.2   #15060      +/-   ##
============================================
- Coverage     41.39%   41.38%   -0.01%     
+ Complexity    10511    10510       -1     
============================================
  Files          1652     1652              
  Lines         71449    71461      +12     
  Branches      10161    10163       +2     
============================================
- Hits          29574    29573       -1     
- Misses        37735    37744       +9     
- Partials       4140     4144       +4
Flag Coverage Δ
integration-tests 38.32% <66.66%> (-0.18%) ⬇️
samples-tests 36.36% <66.66%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AlbumenJ AlbumenJ merged commit a35af27 into apache:3.2 May 16, 2025
19 checks passed
@huangqy17 huangqy17 mentioned this pull request Aug 13, 2025
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlbumenJ @codecov-commenter