HTTP3 bugfix #14955
Merged
HTTP3 bugfix #14955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
AlbumenJ
approved these changes
Dec 2, 2024
finefuture
reviewed
Dec 2, 2024
...tp3/src/main/java/org/apache/dubbo/remoting/transport/netty4/NettyHttp3ConnectionClient.java
Show resolved
Hide resolved
...emoting-http3/src/main/java/org/apache/dubbo/remoting/transport/netty4/NettyHttp3Server.java
Show resolved
Hide resolved
| @@ -80,11 +110,38 @@ public void write(ChannelHandlerContext ctx, Object msg, ChannelPromise promise) | |||
| return; | |||
| } | |||
| ctx.write(new DefaultHttp3DataFrame(frame.content()), promise); | |||
| } else if (msg instanceof Http2PingFrame) { | |||
| sendPing((QuicChannel) ctx.channel()); | |||
There was a problem hiding this comment.
I think implementing a pingpong mechanism for http3 would result in clearer code than reusing http2.
There was a problem hiding this comment.
Considering using the control stream for heartbeat and graceful shutdown, but there is no documentation for this, so had to try it myself and used a simple solution for this version.
There was a problem hiding this comment.
Mark to be resolved later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change?
Checklist