Skip to content

[Bug] Duplicate check in URLParam.class #15326

@cnzakii

Description

@cnzakii

Pre-check

  • I am sure that all the content I provide is in English.

Search before asking

  • I had searched in the issues and found no similar issues.

Apache Dubbo Component

Java SDK (apache/dubbo)

Dubbo Version

dubbo: 3.3+

Steps to reproduce this issue

There’s a redundant check in the URLParam.getRawParam() method: it tests whether rawParam is empty and, if so, calls URLParam.toString(), but toString() itself also checks whether rawParam is empty.

Image

Image

What you expected to happen

We should therefore remove the check from getRawParam() and simply call toString().

Anything else

No response

Are you willing to submit a pull request to fix on your own?

  • Yes I am willing to submit a pull request on my own!

Code of Conduct

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    Status

    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions