Skip to content

[Bug] toCommaDelimitedString(...) returns "null,null" instead of null when all inputs are null #15321

@ankitshokeen

Description

@ankitshokeen

Pre-check

  • I am sure that all the content I provide is in English.

Search before asking

  • I had searched in the issues and found no similar issues.

Apache Dubbo Component

Java SDK (apache/dubbo)

Dubbo Version

Component Affected
dubbo-common

Environment Details
Dubbo version: 3.3.4-SNAPSHOT
JDK version: 17
Operating System: Windows 10

Steps to reproduce this issue

Steps to Reproduce
Call the method:
String result = StringUtils.toCommaDelimitedString(null, (String) null);

What you expected to happen

Expected Behavior
According to the method’s documentation, if either one or others is null, the method should return null. This behavior is expected to prevent invalid string construction from null values.

Actual Behavior
Instead of returning null, the method constructs a string: "null,null", which leads to unexpected results and causes a unit test failure in StringUtilsTest.
expected: <null> but was: <null,null>

Are you willing to submit a pull request to fix on your own?

  • Yes I am willing to submit a pull request on my own!

Code of Conduct

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    Status

    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions