-
Notifications
You must be signed in to change notification settings - Fork 963
Test coverage for unary #2393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test coverage for unary #2393
Conversation
// limitations under the License. | ||
package triple_protocol_test | ||
|
||
import ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
用工具格式化下,这乱七八糟的
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好的
msg := &pingv1.PingResponse{} | ||
err = client.Ping(ctx, triple.NewRequest(&pingv1.PingRequest{Text: text}), triple.NewResponse(msg)) | ||
assert.Nil(t, err) | ||
assert.Equal(t, msg.Text, text) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
如果不想要,就删掉吧
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
流的那一块还有点问题,所以把流的测试注释掉了
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Please run the following command to format import. go get -u github.com/dubbogo/tools/cmd/imports-formatter
imports-formatter |
No description provided.