Skip to content

Fix: cache manager test #2383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 16, 2023
Merged

Fix: cache manager test #2383

merged 2 commits into from
Aug 16, 2023

Conversation

FinalT
Copy link
Member

@FinalT FinalT commented Aug 15, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2023 •
edited
Loading

Codecov Report

Merging #2383 (c9ea8de) into main (1e78aaf) will increase coverage by 0.10%.
The diff coverage is 89.28%.

❗ Current head c9ea8de differs from pull request most recent head 554c808. Consider uploading reports for the commit 554c808 to get more accurate results

@@            Coverage Diff             @@
##             main    #2383      +/-   ##
==========================================
+ Coverage   44.40%   44.50%   +0.10%     
==========================================
  Files         305      305              
  Lines       18618    18628      +10     
==========================================
+ Hits         8267     8291      +24     
+ Misses       9482     9464      -18     
- Partials      869      873       +4
Files Changed Coverage Δ
registry/servicediscovery/store/cache_manager.go 83.72% <88.88%> (+2.14%) ⬆️
...scovery/service_instances_changed_listener_impl.go 2.34% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

justxuewei
justxuewei reviewed Aug 15, 2023
View reviewed changes
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
12.1% 12.1% Duplication

@FinalT FinalT changed the title Fix: Increase the dump interval for cache manager test Fix: cache manager test Aug 15, 2023
chickenlj
chickenlj approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

justxuewei
justxuewei approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@justxuewei justxuewei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks!

@justxuewei justxuewei merged commit 6888010 into apache:main Aug 16, 2023
@FinalT FinalT deleted the fix-cache branch December 29, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexStocks AlexStocks AlexStocks approved these changes

@justxuewei justxuewei justxuewei approved these changes

@chickenlj chickenlj chickenlj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@FinalT @codecov-commenter @AlexStocks @justxuewei @chickenlj