You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix multiple issues in dubbogo-cli when interacting with ZooKeeper as a registry. This PR resolves a panic caused by invalid URL parsing (://dubbo-go-samples-configcenter-zookeeper-client), addresses a "too many colons" error when initializing the ZooKeeper client, and improves error handling for cases where ZooKeeper data is missing (e.g., /dubbo node not found). It also updates the tool to fetch URL data from node content rather than node names, ensuring correct method extraction.
Key changes:
cmd/show.go: Added input validation, passed raw host addresses, and handled errors gracefully with user-friendly output.
metadata/zookeeper/zookeeper.go: Fixed URL parsing by using node content, stripped schemes from addresses, and improved robustness.
Tested with:
Empty ZooKeeper: Displays "No data available" without crashing.
Populated ZooKeeper: Correctly lists interfaces and methods (e.g., org.apache.dubbo.sample.UserProvider with GetUser, UpdateUser).
@Nexusrex18 please pull the develop branch, CI version has been updated. Same with your other PR #2799 still needs to pull the newest change with develop branch.
@Nexusrex18 thx for your contributions. After so many PRs, we dubbo-go team wanna invite you join our developing team in Wechat group which is a Chinese Instant Message chat tool.
Hi @AlexStocks , thank you so much for the invitation and for recognizing my contributions. I’d love to join the dubbo-go developing team. However, WeChat is not available in my country, so I can’t access it easily. Could we use an alternative like Slack, Discord, Telegram, or email instead? I’m happy to adapt to whatever works best for the team. Excited to collaborate more!
Hi @AlexStocks , thank you so much for the invitation and for recognizing my contributions. I’d love to join the dubbo-go developing team. However, WeChat is not available in my country, so I can’t access it easily. Could we use an alternative like Slack, Discord, Telegram, or email instead? I’m happy to adapt to whatever works best for the team. Excited to collaborate more!
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix multiple issues in dubbogo-cli when interacting with ZooKeeper as a registry. This PR resolves a panic caused by invalid URL parsing (
://dubbo-go-samples-configcenter-zookeeper-client), addresses a "too many colons" error when initializing the ZooKeeper client, and improves error handling for cases where ZooKeeper data is missing (e.g.,/dubbonode not found). It also updates the tool to fetch URL data from node content rather than node names, ensuring correct method extraction.Key changes:
cmd/show.go: Added input validation, passed raw host addresses, and handled errors gracefully with user-friendly output.metadata/zookeeper/zookeeper.go: Fixed URL parsing by using node content, stripped schemes from addresses, and improved robustness.Tested with:
org.apache.dubbo.sample.UserProviderwithGetUser, UpdateUser).Fixes: #2681
Signed-off-by: Nexusrex18 lavisnj350@gmail.com