Skip to content

fix issue 2683: defeat memory leak #2792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 10, 2025
Merged

Conversation

LQyt2012
Copy link
Contributor

@LQyt2012 LQyt2012 commented Mar 9, 2025

There is a memory leak when using the dubbo-go-hessian2 protocol(#2683). Since the dubbo-go-hessian2 already fixed in (apache/dubbo-go-hessian2#374) and released a new version with tag v1.12.5. So update the version in dubbo-go.

The rc.id is always nil because it is never assigned.
there is a memory leak in dubbo-go-hessian2, then need to update the version of dubbo-go-hessian2.
@No-SilverBullet
Copy link
Member

please check the CI error

@AlexStocks AlexStocks changed the title fix issue 2683 fix issue 2683: defeat memory leak Mar 9, 2025
@LQyt2012 LQyt2012 closed this Mar 9, 2025
@LQyt2012 LQyt2012 reopened this Mar 9, 2025
Copy link

sonarqubecloud bot commented Mar 9, 2025

Copy link
Member

@No-SilverBullet No-SilverBullet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@No-SilverBullet No-SilverBullet merged commit db2cc25 into apache:develop Mar 10, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants