Fix/remove setdeadline #2785
Merged
Fix/remove setdeadline #2785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…related references to avoid panic
fix:set url to nil when destroy base invoker
reafactor:add comment at BaseInvoker.Destroy()
…onfig options to avoid memory copying and allocation caused by dynamic expansion of slices.
|
FoghostCn
approved these changes
Mar 2, 2025
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
https://pkg.go.dev/net#Conn.SetDeadline
Therefore,
SetDeadlinewill cause the connection to be closed before the server returns completely, soSetDeadlineis removed andSetTimeoutis used instead. In addition,IdleConnTimeoutis added to close idle connections after timeout to avoid invalid reuse.Which issue(s) this PR fixes
#2302