Skip to content

nacos registry support subscribe multi category #2783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 11, 2025
Merged

nacos registry support subscribe multi category #2783

merged 7 commits into from
Mar 11, 2025

Conversation

FoghostCn
Copy link
Contributor

@FoghostCn FoghostCn commented Feb 28, 2025 •
edited
Loading

  • Support subscribing to multiple categories when subscribing to Nacos, not just providers
  • fix the use of handleServiceEvents causes blocking in handling service events.
  • Optimize Nacos subscription logic

Allen442
Allen442 suggested changes Mar 3, 2025
View reviewed changes
@FoghostCn FoghostCn force-pushed the nacos-registry branch 2 times, most recently from 136bbbe to 15431f4 Compare March 3, 2025 11:18
@Allen442
Copy link
Contributor

Allen442 commented Mar 4, 2025

LGTM❤️

@FoghostCn FoghostCn marked this pull request as ready for review March 6, 2025 03:49
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 6, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

No-SilverBullet
No-SilverBullet approved these changes Mar 7, 2025
View reviewed changes
Copy link
Member

@No-SilverBullet No-SilverBullet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@No-SilverBullet No-SilverBullet merged commit ec49b40 into apache:develop Mar 11, 2025
6 checks passed
@AlexStocks AlexStocks mentioned this pull request Mar 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Allen442 Allen442 Allen442 requested changes

@AlexStocks AlexStocks AlexStocks approved these changes

@No-SilverBullet No-SilverBullet No-SilverBullet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FoghostCn @Allen442 @AlexStocks @No-SilverBullet